Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React-Native by moving managerPath export to server.js #2947

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Conversation

Hypnosphi
Copy link
Member

Issue: #2943
This is only present on alpha releases

What I did

Moved managerPath export to server.js

How to test

Launch CRNA example

@codecov
Copy link

codecov bot commented Feb 8, 2018

Codecov Report

Merging #2947 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2947      +/-   ##
==========================================
- Coverage   37.38%   37.37%   -0.02%     
==========================================
  Files         426      426              
  Lines        9153     9151       -2     
  Branches      882      898      +16     
==========================================
- Hits         3422     3420       -2     
- Misses       5174     5184      +10     
+ Partials      557      547      -10
Impacted Files Coverage Δ
app/vue/src/server/config/webpack.config.prod.js 0% <ø> (ø) ⬆️
...p/polymer/src/server/config/webpack.config.prod.js 0% <ø> (ø) ⬆️
app/polymer/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
lib/core/server.js 0% <ø> (ø) ⬆️
app/react/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/vue/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/react/src/server/config/webpack.config.prod.js 0% <ø> (ø) ⬆️
app/angular/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
...p/angular/src/server/config/webpack.config.prod.js 0% <ø> (ø) ⬆️
lib/core/client.js 100% <100%> (ø) ⬆️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 138972f...50591f5. Read the comment docs.

Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hypnosphi Hypnosphi merged commit 7f56358 into master Feb 8, 2018
@Hypnosphi Hypnosphi deleted the fix-rn branch February 8, 2018 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants